DataModules: only instantiate when download requested #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datamodules
adamjstewart
commented
Dec 24, 2022
| @@ -19,7 +19,11 @@ def datamodule(self) -> LoveDADataModule: | |||
| scene = ["rural", "urban"] | |||
|
|
|||
| dm = LoveDADataModule( | |||
There was a problem hiding this comment.
This file will be deleted in #966, this is only temporary
torchgeo/datamodules/naip.py
Outdated
Comment on lines
46
to
47
| :class:`~torchgeo.datasets.NAIP` (prefix keys with naip_) and | ||
| :class:`~torchgeo.datasets.Chesapeake13` (prefix keys with chesapeake_) |
There was a problem hiding this comment.
When I first added this I was lazy and didn't provide a way to separate these. This seems like a good solution to me.
Comment on lines
-106
to
-111
| def prepare_data(self) -> None: | ||
| """Make sure that the dataset is downloaded. | ||
|
|
||
| This method is only called once per run. | ||
| """ | ||
| So2Sat(**self.kwargs) |
There was a problem hiding this comment.
This dataset cannot be automatically downloaded, no reason to prepare_data
isaaccorley
approved these changes
Dec 25, 2022
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* DataModules: only instantiate when download requested * Fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #967